HTTPD default 8Kb header limit check, to avoid 500 Internal Server Error #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP spec does not define a limit, however many servers do by default: Apache 2.0, 2.2: 8K nginx: 4K - 8K IIS: varies by version, 8K - 16K Tomcat: varies by version, 8K - 48K(?!) Ans it is not just with ChormePHP. Some user agents and some requests just get too big for web server defaults. It seems like a silly problem to run into, but it keeps happening.
hopeseekr
changed the title
hopeseekr
force-pushed
the
dulldusk_master
branch
from
7165c1d to
d2c828d
Compare
This was referenced May 15, 2019
peter279k
reviewed
May 15, 2019
| header($header); | ||
| } | ||
|
|
||
| protected function _formatSize($arg) { |
There was a problem hiding this comment.
It looks like this method coding style is not same as other methods.
To be consistency, I think we should fix/organize coding style and I suggest we can follow the PSR-2 coding style :).
And the PHP_CodeSniffer is one of coding style check tool we can consider.
peter279k
reviewed
May 15, 2019
| if ($arg > 0) { | ||
| $j = 0; | ||
| $ext = ["bytes","Kb","Mb","Gb","Tb"]; | ||
| while ($arg >= pow(1024, $j)) ++$j; { |
There was a problem hiding this comment.
I don't think the while loop usage syntax is good.
We should make this while syntax be readable if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ccampbell/chromephp#63:
Also:
Merges ccampbell/chromephp#63, addresses ccampbell/chromephp#40 and ccampbell/chromephp#65.
This change is